Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on base64 gem #1738

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Earlopain
Copy link
Contributor

In #1719 base64`` was added as a dependency to aggregate_root` to prevent warnings/errors in Ruby 3.3/3.4

However there is only one require and no usages of base64 so it can just be removed.

@pjurewicz
Copy link
Contributor

Hey @Earlopain, good catch! Thank you for your contribution

@pjurewicz pjurewicz merged commit cda4ce0 into RailsEventStore:master Feb 7, 2024
87 checks passed
@Earlopain Earlopain deleted the remove-base64-dep branch February 7, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants