Drop specifying default pool size

It's 5 anyway and plain `psql` doesn't know how to handle non-standard DATABASE_URL params.
RailsEventStore · Mar 29, 2024 · 26f810d · 26f810d
1 parent 8cabfb7
commit 26f810d
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 32 deletions.
diff --git a/.github/workflows/dres_rails_test.yml b/.github/workflows/dres_rails_test.yml
@@ -56,31 +56,31 @@ jobs:
         include:
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.2
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.1
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.0
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10011/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10011/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: json
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: jsonb
     steps:
     - uses: actions/checkout@v4

diff --git a/.github/workflows/ruby_event_store-active_record_test.yml b/.github/workflows/ruby_event_store-active_record_test.yml
@@ -96,31 +96,31 @@ jobs:
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10011/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10011/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: json
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: jsonb
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10008/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10008/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10005/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10005/rails_event_store
           data_type: binary
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10008/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10008/rails_event_store
           data_type: json
     steps:
     - uses: actions/checkout@v4

diff --git a/.github/workflows/ruby_event_store-outbox_test.yml b/.github/workflows/ruby_event_store-outbox_test.yml
@@ -77,10 +77,10 @@ jobs:
           database_url: sqlite3:db.sqlite3
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10005/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10005/rails_event_store
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10008/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10008/rails_event_store
     steps:
     - uses: actions/checkout@v4
       with:

diff --git a/.github/workflows/ruby_event_store-rom_test.yml b/.github/workflows/ruby_event_store-rom_test.yml
@@ -86,27 +86,27 @@ jobs:
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10011/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10011/rails_event_store
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: json
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: jsonb
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10008/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10008/rails_event_store
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10005/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10005/rails_event_store
           data_type: text
     steps:
     - uses: actions/checkout@v4

diff --git a/.github/workflows/ruby_event_store-sequel_test.yml b/.github/workflows/ruby_event_store-sequel_test.yml
@@ -86,27 +86,27 @@ jobs:
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10011/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10011/rails_event_store
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: json
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: postgres://postgres:secret@localhost:10015/rails_event_store?pool=5
+          database_url: postgres://postgres:secret@localhost:10015/rails_event_store
           data_type: jsonb
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10008/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10008/rails_event_store
           data_type: text
         - ruby_version: ruby-3.3
           bundle_gemfile: Gemfile
-          database_url: mysql2://root:[email protected]:10005/rails_event_store?pool=5
+          database_url: mysql2://root:[email protected]:10005/rails_event_store
           data_type: text
     steps:
     - uses: actions/checkout@v4

diff --git a/support/ci/generate b/support/ci/generate
@@ -35,13 +35,13 @@ class CI
     SQLITE3 = "sqlite3:db.sqlite3",
     POSTGRES = [
       POSTGRES_15 =
-        "postgres://postgres:secret@localhost:10015/rails_event_store?pool=5",
+        "postgres://postgres:secret@localhost:10015/rails_event_store",
       POSTGRES_11 =
-        "postgres://postgres:secret@localhost:10011/rails_event_store?pool=5"
+        "postgres://postgres:secret@localhost:10011/rails_event_store"
     ],
     MYSQL = [
-      MYSQL_8 = "mysql2://root:[email protected]:10008/rails_event_store?pool=5",
-      MYSQL_5 = "mysql2://root:[email protected]:10005/rails_event_store?pool=5"
+      MYSQL_8 = "mysql2://root:[email protected]:10008/rails_event_store",
+      MYSQL_5 = "mysql2://root:[email protected]:10005/rails_event_store"
     ]
   ].flatten