add initial embedded-hal v1 implementations for pins, delays & PWM
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry, I was too fast about merging the dependabot PRs :( Can you please rebase your patch series ontop of latest |
this does not yet implement any 1.0.0 APIs, this is just a first step to make them available for implementation. the existing v0.2 dependency is being kept but is internally renamed to `embedded-hal-v0`. the re-export as `avr_hal_generic::hal` still points to v0. v1 APIs can now be implemented step-by-step. once all APIs are implemented the v0 APIs can be removed as a breaking change.
the implementation for nanoseconds will only do so with microsecond-accuracy as there's currently no implementation for ns. this is ok(-ish), as the trait allows to delay for longer than specified. if an implementation with us-accuracy can be done this can be done so later as a follow-up. the ns-implementation is done explicitly as the blanket implementation would otherwise transform it into us-calls which then lose precision. the ms-implementation was left to the blanket-implementation as it correctly steps it down to ns, as is also done for the old v0 implementations.
this is the same as `uno-blink.rs`, however the actual blinking is done by a function which does not make any use of any `avr-hal` specific APIs, instead it solely relies on `embedded-hal` v1 traits. note that the current v1.0.0-rc.3 version of `embedded-hal` still has `toggle` as a separate trait fn on `ToggleableOutputPin`, however that has been removed and v1.0.0 will ship with a blanket impl of `toggle` in `StatefulOutputPin`. so when updating to v1.0.0 the manual `set_low`/`set_high` calls can be removed, making the implementation equivalent to `uno-blink.rs`.
this also ships with an example making use of it. note that the fading of the new example is faster than the existing `uno-simple-pwm.rs` example, since the latter fades with 255 steps while the new example uses 0 - 100% percent (and thus only sleeps 200 * 10ms instead of 512 * 10ms).
rursprung
force-pushed
the
add-embedded-hal-v1
branch
from
48584e1
to
0d8b3e5
Compare
no worries. i've rebased & pushed it again. |
Rahix
approved these changes
Dec 24, 2023
Comment on lines
-15
to
+18
| [dependencies.embedded-hal] | ||
| [dependencies.embedded-hal-v0] | ||
| version = "0.2.3" | ||
| package = "embedded-hal" |
There was a problem hiding this comment.
Thanks for doing it this way, it makes the transition so much easier :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a first step towards implementing
embedded-halv1 traits.see the individual commit messages for further details.
this is as far as i'll take it in terms of implementation, as i only have an arduino uno lying around and currently don't have any peripherals to test with. however, this is a starting point for others to add the trait implementations which they'll need.
namely the SPI & I2C traits are not implemented. all other traits from
embedded-halshould be implemented with this PR. note that some traits from v0 were moved to other crates (e.g.embedded-io) or were removed in v1.see also #468