Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MID 0002 Implementation #4

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

ferm10n
Copy link
Collaborator

@ferm10n ferm10n commented Mar 28, 2023

context

st-one-io#40

@ferm10n ferm10n mentioned this pull request Mar 28, 2023
9 tasks
see the comments on this MR st-one-io#41
@ferm10n ferm10n force-pushed the 40-fix-mid0002-parser-missing-keys branch from db8f38b to 6c64d0f Compare March 28, 2023 17:56
@ferm10n
Copy link
Collaborator Author

ferm10n commented Mar 28, 2023

A PR for this branch was also created in the upstream project, and outlines a few concerns with the changes to the payload and the tests st-one-io#41

@ferm10n
Copy link
Collaborator Author

ferm10n commented Mar 28, 2023

The CI job is failing, but so does develop. In fact, this branch produces one less failing test than develop: Should close connection, fail send keepAlive by retry and timeout - Based Test 30/08/2018

@joshpruett
Copy link

Are you concerned about this error @ferm10n? If not, I think it's fine to approve.

  3) Open Protocol Parser
       should emit an error when input is not a buffer:
     TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of Object
      at new NodeError (node:internal/errors:387:5)
      at _write (node:internal/streams/writable:314:13)
      at OpenProtocolParser.Writable.write (node:internal/streams/writable:336:10)
      at Context.<anonymous> (test/openProtocolParser.spec.js:32:16)
      at processImmediate (node:internal/timers:466:21)

@ferm10n
Copy link
Collaborator Author

ferm10n commented Mar 28, 2023

Are you concerned about this error @ferm10n? If not, I think it's fine to approve.

  3) Open Protocol Parser
       should emit an error when input is not a buffer:
     TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of Object
      at new NodeError (node:internal/errors:387:5)
      at _write (node:internal/streams/writable:314:13)
      at OpenProtocolParser.Writable.write (node:internal/streams/writable:336:10)
      at Context.<anonymous> (test/openProtocolParser.spec.js:32:16)
      at processImmediate (node:internal/timers:466:21)

This was a failing test on develop so I think it's fine.

@ferm10n ferm10n merged commit 3a5c96e into develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants