fix: properly destroy streams when an error occurs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `_destroy` noops were removed since they prevent proper propagation of errors - not sure what this needed for backwards compat, but I assume it was added after node 10 defaulted `autoDestroy: true` - tweaked some types on constructor options - added a catch around the mid serializer fn, without which it would cause an unhandled rejection and silently stop working
|
Because there isn't a minimum supported node version specified anywhere, I assume that there's no need for handling a breaking change |
joshpruett
approved these changes
Mar 28, 2023
ferm10n
commented
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
st-one-io#33
changes summary
_destroynoops were removed since they prevent proper propagation of errorsautoDestroy: true