Fixed Switch's incorrect button layout & Case Insensitivity #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonic-Geared
changed the title
apparently this was broken so i decided to fix it and also complete the todo of looking at the original impl in the other versions and instead of a return false it was a break, amazing ig
Sonic-Geared
changed the title
Sonic-Geared
changed the title
Mefiresu
requested changes
Jan 16, 2024
RSDKv5/RSDK/Core/Reader.cpp
Outdated
Comment on lines
244
to
249
| // Fixes ".ani" ".Ani" bug and any other case differences | ||
| char pathLower[0x100]; | ||
| memset(pathLower, 0, sizeof(pathLower)); | ||
| for (int32 c = 0; c < strlen(filename); ++c) pathLower[c] = tolower(filename[c]); | ||
| memset(pathLower, 0, sizeof(char) * 0x100); | ||
| for (int32 c = 0; c < strlen(fullFilePath); ++c) { | ||
| pathLower[c] = tolower(fullFilePath[c]); | ||
| } |
There was a problem hiding this comment.
This is equivalent to the old code, I highly doubt it fixes anything.
RSDKv5/RSDK/Core/Reader.cpp
Outdated
| @@ -263,7 +266,7 @@ bool32 RSDK::LoadFile(FileInfo *info, const char *filename, uint8 fileMode) | |||
| } | |||
| if (modSettings.activeMod != -1) { | |||
| PrintLog(PRINT_NORMAL, "[MOD] Failed to find file %s in active mod %s", filename, modList[m].id.c_str()); | |||
| // TODO return false? check original impl later | |||
| break; // no one ever checked the original implementation... :pensive: | |||
There was a problem hiding this comment.
This skips all following mods in the mod list.
There was a problem hiding this comment.
i see, weirdly enough that is how the other decomps do the stuff related to that, but yeah i'll try to look into it further
hey, it's me goku! and i'm a super saiyan!
|
SHIT, accidentally pressed a thing from the review stuff, sorry if it notificates you mephiles :( |
|
Closing your PR for now because I feel like it doesn't fix anything:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a issue where the AB/Confirm & Back buttons on NX/Switch controllers would be swapped compared to the official Mania/RSDKv5, as reported in issue #108
And also fixes a problem where the files needed to be Case Insensitive (atleast on Legacy v3 mode, for what is told in the description of it), as reported in issue #214