-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cellSaveData: Add autosave indicator #15720
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
It's not relevant for RPCS3, our saves are superior. |
y_offset += (spacing + it->h); | ||
} | ||
else | ||
else if (origin == message_pin_location::bottom) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a switch
case CELL_SAVEDATA_INDICATORPOS_LOWER_RIGHT: | ||
msg_location = rsx::overlays::message_pin_location::bottom_right; | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing default
msg_text = localized_string_id::CELL_SAVEDATA_AUTOLOAD; | ||
} | ||
|
||
u32 indicator_pos = (statSet->indicator->dispPosition & 0x0F); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u32 indicator_pos = (statSet->indicator->dispPosition & 0x0F); | |
const u32 indicator_pos = (statSet->indicator->dispPosition & 0x0F); |
Was testing something / not intended for merge yet |
Did you forget about the review changes @NicknineTheEagle ? |
Ah, sorry - no, I didn't forget, I was just procrastinating on this because I need to add UI element to toggle the feature and I really don't like working with anything UI. |
if this PR is still valid on top of the current RPCS3, isn't it good to be merged (applying the changes provided by megamouse) and then someone else could make this feature configurable on the GUI, if necessary? |
This adds standard autosave and autoload indicators that would appear on PS3 when the game requests them. Since RPCS3 saves basically instantaneously, this auto indicator simply appears for a few seconds to let the user known when the game autosaves.