Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Git revision date localized plugin added #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TOTON95
Copy link
Contributor

@TOTON95 TOTON95 commented Jun 11, 2024

This PR starts adding plugins listed in #43, specifically mkdocs-git-revision-date-localized-plugin.

Suggestions/Corrections are very welcomed.

@TOTON95 TOTON95 requested a review from knmcguire June 11, 2024 04:27
Copy link
Member

@knmcguire knmcguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks! Very nice addition.

Currently it says 11th of June as last updated date, but I guess there is no way around it since this includes an actual update. I'm trying to think how to solve that but probably no easy solution for that...

@TOTON95
Copy link
Contributor Author

TOTON95 commented Jun 11, 2024

Hi and thanks! Very nice addition.

Currently it says 11th of June as last updated date, but I guess there is no way around it since this includes an actual update. I'm trying to think how to solve that but probably no easy solution for that...

Yes @knmcguire, that's unfortunately the problem if included directly. I am currently studying the override of themes for mkdocs, and see if that helps since it would be some sort of "include" rather than direct insertion/actual update.

Let me see how it goes, and if it works, I think it might help the goatcounter insertion as well.

@knmcguire
Copy link
Member

Alright, I'll wait for that then. thanks!

I haven't completely figured out how to do that in a nice and clean way either then providing the full adjusted theme in source and I don't think that's a good approach.

@knmcguire
Copy link
Member

have you looked at this recently? We can also just consider just to merge it and be okay with this one time the date being different as a starting point. I don't mind that much personally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants