Add documentation for HIP graphs #3585
Open
+910
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
6 times, most recently
from
e08e750
to
c6b8a28
Compare
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
07dce2f
to
0f98744
Compare
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
2 times, most recently
from
1bfa287
to
4b09a23
Compare
MKKnorr
force-pushed
the
understand-hip-graphs
branch
from
0f98744
to
5f27a8a
Compare
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
2 times, most recently
from
28d1384
to
cb851d9
Compare
|
I sent comments through Teams. |
randyh62
approved these changes
Sep 19, 2024
docs/sphinx/_toc.yml.in
Outdated
| @@ -34,6 +34,8 @@ subtrees: | |||
| title: Unified memory | |||
| - file: how-to/virtual_memory | |||
| title: Virtual memory | |||
| - file: how-to/hipgraph | |||
| title: HIP graph | |||
There was a problem hiding this comment.
I left the title as is, as it will be merged into the HIP Runtime API how-to, and this document currently does more than just explain how to use them
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
from
a30a0b8
to
70e88ee
Compare
MKKnorr
changed the title
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
2 times, most recently
from
4318aea
to
60f8a71
Compare
|
I won't fix the linting failing on a possessive 's, that can (and should) be fixed in the linter in rocm-docs-core |
neon60
reviewed
Sep 23, 2024
neon60
reviewed
Sep 23, 2024
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
from
60f8a71
to
e104730
Compare
neon60
reviewed
Sep 23, 2024
docs/how-to/hipgraph.rst
Outdated
| These memory allocations can also be set up to allow access from multiple GPUs, | ||
| just like normal allocations. HIP then takes care of allocating and mapping the | ||
| memory to the GPUs. When capturing a graph from a stream, the node sets the | ||
| accessibility according to ``hipMemPoolSetAccess`` at the time of capturing. |
There was a problem hiding this comment.
Use cpp:func here too? Referemce reorganize will make this work.
neon60
reviewed
Sep 23, 2024
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
5 times, most recently
from
a76c91a
to
bacdf53
Compare
MKKnorr
force-pushed
the
how-to-hip-graphs
branch
from
bacdf53
to
e811c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "how-to" chapter for HIP graphs.
Note, that it currently is set to be merged with understand-hip-graphs, as it depends on its content, and it already has a PR #3571