Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture fetching #3552

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Texture fetching #3552

merged 4 commits into from
Sep 20, 2024

Conversation

parbenc
Copy link

@parbenc parbenc commented Jul 24, 2024

add page explaining texture fetching in HIP

@parbenc parbenc self-assigned this Jul 24, 2024
@parbenc parbenc changed the title Texture fetching WIP Texture fetching Jul 24, 2024
@parbenc parbenc changed the base branch from develop to docs/develop July 24, 2024 12:46
@parbenc parbenc changed the title WIP Texture fetching WIP - Texture fetching Jul 24, 2024
@parbenc parbenc marked this pull request as ready for review July 29, 2024 12:42
@parbenc parbenc changed the title WIP - Texture fetching Texture fetching Jul 29, 2024
@neon60
Copy link
Contributor

neon60 commented Jul 30, 2024

@parbenc please link the following pages in the document:

@neon60 neon60 added documentation ci:docs-only Only run Read the Docs CI on this PR labels Jul 30, 2024
@neon60
Copy link
Contributor

neon60 commented Jul 30, 2024

Can we alse describe the different modes here:

https://rocm.docs.amd.com/projects/HIP/en/latest/doxygen/html/texture__types_8h.html

hipAddressModeWrap
hipAddressModeClamp  
hipAddressModeMirror  
hipAddressModeBorder

@neon60
Copy link
Contributor

neon60 commented Jul 30, 2024

Please add figures for the different address and filter modes.

@parbenc parbenc force-pushed the texture_fetching branch 2 times, most recently from 7aac395 to de770f8 Compare August 5, 2024 12:58
Copy link

@MKKnorr MKKnorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the sampling methods need a better explanation.

And something I have been wondering: are sampling methods and address modes independent of each other? The sampling methods only show sampling within the indexable range, but don't explain out of range behaviour. If they are independent, then this should be highlighted better

docs/index.md Outdated Show resolved Hide resolved
docs/sphinx/_toc.yml.in Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
@parbenc parbenc force-pushed the texture_fetching branch 3 times, most recently from a13eb26 to 0c38bc2 Compare August 12, 2024 15:02
docs/index.md Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
docs/understand/texture_fetching.rst Outdated Show resolved Hide resolved
@neon60 neon60 merged commit 15f8613 into docs/develop Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs-only Only run Read the Docs CI on this PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants