Skip to content

Commit

Permalink
SWDEV-460816 - Fix files in correct directories
Browse files Browse the repository at this point in the history
Change-Id: I68bf61b9bccfe562f9adda9f09ce8073764ab480
  • Loading branch information
jujiang-del committed May 9, 2024
1 parent 5f692b3 commit 6967baf
Show file tree
Hide file tree
Showing 19 changed files with 193 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Please use the [GitHub Issue](https://github.com/ROCm/HIP/issues) tab to notify

## Acceptance Criteria ##

HIP is a C++ Runtime API and Kernel Language that allows developers to create portable applications for AMD and NVIDIA GPUs from single source code. Contributors wishing to submit new HIP Features (ie functions, classes, types) should also consider CUDA APIs.
HIP is a C++ Runtime API and Kernel Language that allows developers to create portable applications for AMD and NVIDIA GPUs from single source code. Contributors wishing to submit new HIP Features (ie functions, classes, types) should resemble CUDA APIs.
Differences or limitations of HIP APIs as compared to CUDA APIs should be clearly documented and described.
Some guidelines are outlined below:

Expand Down Expand Up @@ -51,6 +51,7 @@ For applications and benchmarks outside the hip-tests environment, developments
- Use 4 spaces indentation.
- Capitalization and Naming
- Prefer camelCase for HIP interfaces and internal symbols. Note HCC uses _ for separator.
This guideline is not yet consistently followed in HIP code - eventual compliance is aspirational.
- Member variables should begin with a leading "_". This allows them to be easily distinguished from other variables or functions.

- `{}` placement
Expand Down
187 changes: 187 additions & 0 deletions docs/data/hardware_implementation/compute_unit.drawio

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions docs/data/hardware_implementation/compute_unit.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 6967baf

Please sign in to comment.