-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and remove individual hands #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this alleviates a bit the role of the inventory. Inventory should only handles what's on the player or hold by them. Opened Containers by the player should be displayed using another script, dedicated to that.
this prevents the conflit with Inventory namespace
stilnat
changed the title
[WIP] Add and remove individual hands
Add and remove individual hands
Aug 3, 2023
iamteapot422
requested changes
Aug 8, 2023
Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/AddHandCommand.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/AddHandCommand.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/AddHandCommand.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/AddHandCommand.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/SS3D/Systems/IngameConsoleSystem/Commands/AddHandCommand.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/SS3D/Systems/Inventory/Containers/InventoryView.cs
Outdated
Show resolved
Hide resolved
…ndCommand.cs Co-authored-by: Iamteapot <[email protected]>
…ndCommand.cs Co-authored-by: Iamteapot <[email protected]>
…ndCommand.cs Co-authored-by: Iamteapot <[email protected]>
…ndCommand.cs Co-authored-by: Iamteapot <[email protected]>
…ndCommand.cs Co-authored-by: Iamteapot <[email protected]>
Co-authored-by: Iamteapot <[email protected]>
Co-authored-by: Iamteapot <[email protected]>
Co-authored-by: Iamteapot <[email protected]>
…ndCommand.cs Co-authored-by: Iamteapot <[email protected]>
…to Individual-hands
iamteapot422
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the inventory rework, this makes hands works properly when they are added or removed.
Currently, hands are controlled by a unique script, Hands.cs. This add another script, Hand.cs, representing a single hand.
Hands.cs becomes a controller for each hand on the player.
Server and client methods are also properly separated and varaibles synced, allowing only server to do things such as removing hands.
When a hand is removed, if it was the active hand, then another available hand become active, or none if there's none left.
It integrates nicely with interactions, as with no hands left it won't throw exceptions if the player tries to interact.
This is necessary to move on with basic health, as this will allow loosing hands properly.
File changes
https://youtu.be/6u2Og_aA63w
TODO
Known issues
no known issues
Fixes (optional)
no known fixes