Smoother embark and game screens refactor #1213
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
A few changes to do, seems to work fine with host (I need to mess around more), not tested with client yet. Also need to check if there's conflict with the inventory rework, probably minor ones but please let's do that before any merge, I don't my whole work wasted.
|
|
||
| namespace SS3D.Systems.Screens | ||
| { | ||
| public static class GameScreens |
There was a problem hiding this comment.
For the sake of clarity, it'd be nice if you could add the [Server] [Client] [ServerOrClient] attributes on relevant methods. That way we understand better what execute what and it limits error due to server or client calling methods they're not supposed to.
| @@ -12,72 +14,51 @@ namespace SS3D.Systems.Screens | |||
| /// </summary> | |||
| public class GameScreen : Actor | |||
| { | |||
| [SerializeField] private ScreenType _screenType; | |||
| public ScreenType ScreenType; | |||
There was a problem hiding this comment.
Should this stay private ?
| using SS3D.Systems.Entities.Events; | ||
| using UnityEngine; | ||
|
|
||
| namespace SS3D.Systems.Entities.UI |
There was a problem hiding this comment.
What's this script for, please add comments
|
Client breaks the container UI, please check if this happen on develop already, and if not, please fix before merge |
This reverts commit 05795f0.
stilnat
dismissed
cosmiccoincidence’s stale review
requested changes have been made
Summary
This PR reworks how the game screens work internally, adds a fade out when the player enters the game, creates a ScriptableSettings script to define how general UI works. Reorder objects around the game scene, and creates prefabs from a few objects on the game scene.