Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace html5lib with html5lib-modern #2911

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Replace html5lib with html5lib-modern #2911

merged 3 commits into from
Oct 1, 2024

Conversation

ashleysommer
Copy link
Contributor

Replace html5lib with html5lib-modern

This removes another source of six dependency.
Fixes #2749

Note however, this is not the last source of six sub-dependency.

The isodate module used in RDFLib also depends on six, and also hasn't been updated in over 3 years, (though it is not marked as deprecates like html5lib)

The path to fix, upgrade or replace isodate is not so clear.

@coveralls
Copy link

Coverage Status

coverage: 90.649%. first build
when pulling fee0531 on html5lib-modern
into 64b778c on main.

@ashleysommer
Copy link
Contributor Author

Update on the isodate issue, looks like that package is maintained by our colleague Gerhard at TERN, so he might be able to push out a new version with no six dependency.

@ashleysommer
Copy link
Contributor Author

If there is no opposition, I will merge this on Monday.

@nicholascar
Copy link
Member

Waiting to see if the new html5lib release removes six

@nicholascar nicholascar self-requested a review September 30, 2024 13:30
@ashleysommer
Copy link
Contributor Author

Waiting to see if the new html5lib release removes six

Actually I misinterpreted the situation. The original author has not put out a new html5lib release, and more projects are now moving to html5-modern.

@ashleysommer ashleysommer merged commit 0b69f4f into main Oct 1, 2024
22 checks passed
@ashleysommer ashleysommer deleted the html5lib-modern branch October 1, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: move away from deprecated html5lib
3 participants