Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
One of the assertions in
test_datetime_z
seems to be performing operations in the wrong order. This also means it's passing trivially, as it's essentially recreating the expected result string and asserting it's not empty.This PR changes the test to what I think was the intended order of operations:
l.toPython()
) according to the given format stringChecklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.