Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if multiple prefixes for the same IRI persist in a namespace manager #2800

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

white-gecko
Copy link
Member

Summary of changes

This pull request so far introduces some failing tests, that demonstrate that the namespace manager is not able to maintain multiple prefixes for the same IRI, as mentioned in #2077 .

Roughly related to #2779, as it also cares about parsing/serialization side effects.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes. 🛑
  • If the change adds new features or changes the RDFLib public API:
    • Created an issue to discuss the change and get in-principle agreement.
    • Considered adding an example in ./examples.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@nicholascar
Copy link
Member

@white-gecko are you going to move this from Draft to ready?

@nicholascar nicholascar added the awaiting feedback More feedback is needed from the author of the PR or Issue. label Jul 24, 2024
@white-gecko
Copy link
Member Author

So far these are just failing tests, for which it is required to fix the namespace manager accordingly. So it is not ready to be merged until an implementation follows. You could also close it, to have it out of the way and we reopen it, once an improved namespace manager is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback More feedback is needed from the author of the PR or Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants