style: eliminate unused noqa
statements
#2566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This change enables RUF100 ("Unused noqa directive") and removes all the
noqa
directives that are no longer needed.This is done with
poetry run ruff check --fix .
, which also removesnoqa
directives that are not needed because of ruff config, like E402.This change also removes file level ignores for some python files in
favour of
noqa
directives. This is to avoid removingnoqa
directivesthat will just be added back later.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.