Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: eliminate unused noqa statements #2566

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Sep 3, 2023

Summary of changes

This change enables RUF100 ("Unused noqa directive") and removes all the
noqa directives that are no longer needed.

This is done with poetry run ruff check --fix ., which also removes
noqa directives that are not needed because of ruff config, like E402.

This change also removes file level ignores for some python files in
favour of noqa directives. This is to avoid removing noqa directives
that will just be added back later.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This change enables RUF100 ("Unused noqa directive") and removes all the
`noqa` directives that are no longer needed.

This is done with `poetry run ruff check --fix .`, which also removes
`noqa` directives that are not needed because of ruff config, like E402.

This change also removes file level ignores for some python files in
favour of `noqa` directives. This is to avoid removing `noqa` directives
that will just be added back later.
@aucampia aucampia merged commit ac71f95 into RDFLib:main Sep 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant