-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 939 return cg from parse #2563
base: main
Are you sure you want to change the base?
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mielvds thanks for this, this is a breaking change, so I will hold off a little with merging it, as I want to release 7.0.1 or 7.1 in the next weeks, but I will merge it soon afterwards.
Note, with impending removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve this but for the RDFLib 8.0.0 release (Sept 2024??) in since the major version number change will be appropriate for the API change.
We will need to remove the ConjunctiveGraph
handling though as CG will be removed in 8.0.0, so we will end up with just Dataset
for quad graphs.
Summary of changes
Fixes #939, which was really easy to do since most of the logic moved out of the CG parse method. Not sure whether this needed additional discussion or not; it does change the public API
Checklist
the same change.
./examples
.so maintainers can fix minor issues and keep your PR up to date.