Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for CG operator return type #2557

Merged

Conversation

mielvds
Copy link
Contributor

@mielvds mielvds commented Aug 30, 2023

Summary of changes

Test case for #652, which seems to indicate that the issue has already been solved

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Aug 30, 2023

Coverage Status

coverage: 90.94%. remained the same when pulling c5c54a0 on mielvds:fix-652-sum-of-conjunctive-graph-return-type into 247ddb5 on RDFLib:main.

@aucampia
Copy link
Member

pre-commit.ci autofix

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests to confirm the issue can be closed.

@aucampia aucampia merged commit e42b752 into RDFLib:main Aug 30, 2023
15 checks passed
@mielvds
Copy link
Contributor Author

mielvds commented Aug 31, 2023

cool! Don't forget to close #652

@aucampia
Copy link
Member

cool! Don't forget to close #652

Done now, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants