-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UIGestureRecognizer #122
Open
siemensikkema
wants to merge
15
commits into
RACCommunity:master
Choose a base branch
from
siemensikkema:gesture_recognizer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support UIGestureRecognizer #122
siemensikkema
wants to merge
15
commits into
RACCommunity:master
from
siemensikkema:gesture_recognizer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siemensikkema
commented
May 25, 2016
- contains rex_action and rex_enabled
- includes test
- clean up UIButtonTests
I will test this as soon has I have time. Thanks @siemensikkema ! |
@siemensikkema can you rebase? |
* Add userInteractionEnabled to UITableViewCell This allows the binding of a Bool to the cell's userInteractionEnabled attribute. * Move code into correct file * Remove UITableViewCell.swift file from root dir * Revert UITableViewCell.swift to original * Add userInteractionEnabled to UIView * Update comments in UIView.swift sorry for the commit spamming 😁 * Add testUserInteractionEnabledProperty
* Provide a `setUp` to properly configure the associated property The introduced `setUp` is extremely helpful to setup any signals that may affect the property once. * Add bindable property to wrap a control's value This property is common to every `UIControl` and can be used by providing a getter and a setter for the value wrapped. This property uses `UIControlEvents.ValueChanged` and `UIControlEvents.EditingChanged` events to detect changes and keep the value up-to-date. This kind of logic can be reused instead of being defined and used for each control. * Use `setUp` to install the dependent signal of `rex_dismissAnimated` This prevents repetition of events in cases where the property is accessed more than once (each access adds a new `rac_signalForSelector` for the dismiss of the view controller). * Fixes #129 - UITextField's text bindable property should be of optional type
@RuiAAPeres done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.