-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detail a list of available pytest plugins to perform parallel exploration #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andfoy! Generally looks good to me, with just a couple of things to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the section on pytest plugins should come first, since that's the better way to get started. As written now, doing the same thing manually is probably only useful to:
- test only a small subset of functionality with concurrent execution,
- being able to run some concurrent tests without having to add a new test dependency
Anything else? It would be good to explain why that large and complex code block is shown (i.e., the reasons above), and if the rationale for it is quite thin then consider hiding it in a foldout or in a note/info block where it gets rendered in smaller font.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a few copy-edits, LGTM now. Thanks @andfoy & reviewers!
See #86 (comment)