Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail a list of available pytest plugins to perform parallel exploration #108

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

andfoy
Copy link
Member

@andfoy andfoy commented Nov 5, 2024

Copy link
Collaborator

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andfoy! Generally looks good to me, with just a couple of things to fix.

docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
@rgommers rgommers added the documentation Improvements or additions to documentation label Nov 5, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the section on pytest plugins should come first, since that's the better way to get started. As written now, doing the same thing manually is probably only useful to:

  1. test only a small subset of functionality with concurrent execution,
  2. being able to run some concurrent tests without having to add a new test dependency

Anything else? It would be good to explain why that large and complex code block is shown (i.e., the reasons above), and if the rationale for it is quite thin then consider hiding it in a foldout or in a note/info block where it gets rendered in smaller font.

docs/debugging.md Outdated Show resolved Hide resolved
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a few copy-edits, LGTM now. Thanks @andfoy & reviewers!

@rgommers rgommers merged commit f72e950 into main Nov 6, 2024
2 checks passed
@rgommers rgommers deleted the list_pytest_plugins branch November 6, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants