Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds use_fractional_gates option #83

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

y4izus
Copy link
Collaborator

@y4izus y4izus commented Sep 18, 2024

Summary

Fixes #82

@y4izus y4izus self-assigned this Sep 18, 2024
@y4izus y4izus marked this pull request as ready for review September 18, 2024 09:07
Copy link
Contributor

@jesus-talavera-ibm jesus-talavera-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


@pytest.mark.parametrize(
"valid_use_fractional_gates_param",
["no", "n", "false", "f", "0", "yes", "y", "true", "t", "1"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I didn't know there were so many ways to pass true or false 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither me, I discovered it trying to use "yes" as a non valid value 😂

@y4izus y4izus merged commit ac02120 into main Sep 18, 2024
4 checks passed
@y4izus y4izus deleted the yg-use-fractional-gates-option branch September 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add use_fractional_gates option
3 participants