Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing again issues with ecr_.* names #74

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

cbjuan
Copy link
Member

@cbjuan cbjuan commented Sep 17, 2024

Summary

Fixes issues with ECR gates. Fixes #73 and continues #63

Details and comments

As commented in the issue, this issue comes from Qiskit

Changes verified using the following code:

from qiskit.circuit import QuantumCircuit
from qiskit_ibm_transpiler.transpiler_service import TranspilerService
from qiskit_ibm_runtime import QiskitRuntimeService

num_qubits = 16
circuit = QuantumCircuit(num_qubits)
for i in range(num_qubits - 1):
    circuit.ecr(i, i + 1)

runtime_service = QiskitRuntimeService(channel="ibm_quantum")
backend = runtime_service.backend("ibm_strasbourg")

cloud_transpiler_service = TranspilerService(
    backend_name="ibm_strasbourg",
    ai="false",
    optimization_level=3,
)
transpiled_circuit = cloud_transpiler_service.run(circuit)
print([data.name for data in transpiled_circuit.data])

@cbjuan cbjuan added the bug Something isn't working label Sep 17, 2024
Copy link
Contributor

@jesus-talavera-ibm jesus-talavera-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added tests along with @y4izus

@jesus-talavera-ibm jesus-talavera-ibm merged commit 38f3182 into main Sep 17, 2024
4 checks passed
@jesus-talavera-ibm jesus-talavera-ibm deleted the fix-ecr-gates-issue-again branch September 17, 2024 08:38
jesus-talavera-ibm added a commit that referenced this pull request Sep 17, 2024
* Fixing again issues with ecr_.* names

* [skip ci] Adding release note

* Rename unreleased rst file

* Add test for ECR gates with ibm_strasbourg

---------

Co-authored-by: Yaiza <[email protected]>
Co-authored-by: Jesus Talavera <[email protected]>
jesus-talavera-ibm added a commit that referenced this pull request Sep 17, 2024
* Fixing again issues with ecr_.* names

* [skip ci] Adding release note

* Rename unreleased rst file

* Add test for ECR gates with ibm_strasbourg

---------

Co-authored-by: Yaiza <[email protected]>
Co-authored-by: Jesus Talavera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service creates ECR instructions that are incompatible with IBM Strasbourg
3 participants