Use QPY as exchange format #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesus-talavera-ibm
requested review from
cbjuan,
d-kremer,
victor-villar and
y4izus
as code owners
This reverts commit 505fea3.
cbjuan
reviewed
Nov 9, 2024
| @@ -66,8 +67,8 @@ def transpile( | |||
|
|
|||
| results = [] | |||
| for transpile_resp in transpile_resps: | |||
| if transpile_resp.get("success") and transpile_resp.get("qasm") is not None: | |||
| results.append(QuantumCircuit.from_qasm_str(transpile_resp.get("qasm"))) | |||
| if transpile_resp.get("success") and transpile_resp.get("qpy") is not None: | |||
There was a problem hiding this comment.
If we can send the circuits as qasm because of the fallback, couldn’t we receive the result in qasm format too?
if so, we should add it to this part of the method
There was a problem hiding this comment.
Good catch! I simplified the logic using deserialize_circuit_from_qpy_or_qasm() function
| if transpile_resp.get("success") and transpile_resp.get("qasm") is not None: | ||
| results.append(QuantumCircuit.from_qasm_str(transpile_resp.get("qasm"))) | ||
| if transpile_resp.get("success") and transpile_resp.get("qpy") is not None: | ||
| results.append(get_circuit_from_qpy(transpile_resp.get("qpy"))) |
| if transpile_resp.get("success") and transpile_resp.get("qasm") is not None: | ||
| results.append(QuantumCircuit.from_qasm_str(transpile_resp.get("qasm"))) | ||
| if transpile_resp.get("success") and transpile_resp.get("qpy") is not None: | ||
| results.append(get_circuit_from_qpy(transpile_resp.get("qpy"))) |
tests/test_transpiler_service.py
Outdated
| @@ -409,6 +430,14 @@ def test_fix_ecr_qasm3(): | |||
| assert isinstance(list(circuit_from_qasm)[0].operation, ECRGate) | |||
|
|
|||
|
|
|||
| def test_fix_ecr_qpy(): | |||
There was a problem hiding this comment.
I’d say this is not needed with QPY
There was a problem hiding this comment.
You are right. Thank you!
cbjuan
approved these changes
Nov 11, 2024
jesus-talavera-ibm
added a commit
that referenced
this pull request
Nov 11, 2024
* Use QPY as exchange format * Fix tests * Fix tests for QuantumVolume * Add test to check wrong input circuits * Convert last tests that were using QASM * Add ecr test for qpy * Add fix to avoid random test errors * Revert "Add fix to avoid random test errors" This reverts commit 505fea3. * Add release notes * Accept only QuantumCircuit as input * Fix tests * Use QASM as fallback serialization format if QPY fails * Fix test_layout_construction_no_service * Fix code for Python 3.8 * Add testcase for qpy fallback * Code review suggestions
jesus-talavera-ibm
added a commit
that referenced
this pull request
Nov 11, 2024
* Use QPY as exchange format * Fix tests * Fix tests for QuantumVolume * Add test to check wrong input circuits * Convert last tests that were using QASM * Add ecr test for qpy * Add fix to avoid random test errors * Revert "Add fix to avoid random test errors" This reverts commit 505fea3. * Add release notes * Accept only QuantumCircuit as input * Fix tests * Use QASM as fallback serialization format if QPY fails * Fix test_layout_construction_no_service * Fix code for Python 3.8 * Add testcase for qpy fallback * Code review suggestions
jesus-talavera-ibm
added a commit
that referenced
this pull request
Nov 11, 2024
This reverts commit bd3bf1c.
jesus-talavera-ibm
added a commit
that referenced
this pull request
Nov 11, 2024
* Use QPY as exchange format * Fix tests * Fix tests for QuantumVolume * Add test to check wrong input circuits * Convert last tests that were using QASM * Add ecr test for qpy * Add fix to avoid random test errors * Revert "Add fix to avoid random test errors" This reverts commit 505fea3. * Add release notes * Accept only QuantumCircuit as input * Fix tests * Use QASM as fallback serialization format if QPY fails * Fix test_layout_construction_no_service * Fix code for Python 3.8 * Add testcase for qpy fallback * Code review suggestions
jesus-talavera-ibm
added a commit
that referenced
this pull request
Nov 11, 2024
* Use QPY as exchange format * Fix tests * Fix tests for QuantumVolume * Add test to check wrong input circuits * Convert last tests that were using QASM * Add ecr test for qpy * Add fix to avoid random test errors * Revert "Add fix to avoid random test errors" This reverts commit 505fea3. * Add release notes * Accept only QuantumCircuit as input * Fix tests * Use QASM as fallback serialization format if QPY fails * Fix test_layout_construction_no_service * Fix code for Python 3.8 * Add testcase for qpy fallback * Code review suggestions
jesus-talavera-ibm
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #103
Details and comments