major rewrite of the algorithms #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeileiZeng
approved these changes
Aug 7, 2024
|
Dear Weilei:
For next time, there is a button for review on the pull request page.
There, you should press to approve it.
This is part of the common protocol for github development.
Also there, you are able to review the code, add comments or suggested
changes there.
Ideally, we should add tests (other than the current "it compiles" test so
that breaking changes would not inadvertently be pushed into the master
branch...
Thanks
Leonid
…On Tue, Aug 6, 2024 at 6:38 PM Radish Meeting ***@***.***> wrote:
***@***.**** approved this pull request.
I have run the code on my local linux machine. Things work smoothly.
—
Reply to this email directly, view it on GitHub
<#4 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APF4LTQATNZVBYCR4B23BTLZQF275AVCNFSM6AAAAABL5M6FLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRSGQ4DANRRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.