Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled error page in books buy, added error page #260

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

c99SRS
Copy link
Contributor

@c99SRS c99SRS commented Oct 9, 2022

Fixes #(issue number)

#250

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Added error page, handled error while buying books

Deploy your changes to github page or netlify and mention deployment link:

Add the deployment link here.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.
NA

Additional context (OPTIONAL)

You can also configure this error page while configuring it in NGINX.

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.
How someone can test your code?

Checklist

  • [250 ] I have mentioned related issue number in PR description.
  • I have added screenshots and related demo links of my changes..
  • The title of my pull request is a short description of the requested changes.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@QAZIMAAZARSHAD
Copy link
Owner

@c99SRS go through the entire website and replace the dummy page with error.html.

and add hyperlinks to the error page wherever it is required.

@c99SRS
Copy link
Contributor Author

c99SRS commented Oct 9, 2022

Sure @QAZIMAAZARSHAD

@c99SRS
Copy link
Contributor Author

c99SRS commented Oct 9, 2022

HI @QAZIMAAZARSHAD I have updated all the dummy pages with an error pages. please review it and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants