fix: Checker buttons doesn't work #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug that happens due to race condition. We improved the <span> detection too much, and it caused a race condition where the fileId etc aren't defined when we're tracking the buttons. The solution is to define loading order using event listeners.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yammesicka - I've reviewed your changes and they look great!
General suggestions:
- Ensure that the new event names introduced are unique enough to avoid potential conflicts with existing or future code.
- Review the overall event-driven modifications to confirm they align with the application's architecture and coding standards.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -250,6 +251,11 @@ window.addEventListener('load', () => { | |||
| sessionStorage.setItem('solverId', codeElementData.solverId); | |||
| sessionStorage.setItem('allowedComment', codeElementData.allowedComment); | |||
| customElements.define('comment-line', LineComment); | |||
| window.dispatchEvent(new Event('defined-window-variables')); | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider the potential for event name collisions.
Using a very generic event name like 'defined-window-variables' might lead to conflicts with other scripts or future features. Consider a more specific naming convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug that happens due to race condition.
We improved the detection too much, and it caused a race condition where the fileId etc aren't defined when we're tracking the buttons.
The solution is to define loading order using event listeners.