Add HasIndividualRegistration #897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avigation flow based on it.
digit01Wave
reviewed
Aug 26, 2023
| return await dbContext.PlayerInEvent.Where(p => p.PlayerId == ID && p.EventId == thisEvent.ID).AnyAsync(); | ||
| } | ||
|
|
||
| return await dbContext.TeamMembers.Where(tm => tm.Member.ID == ID && tm.Team.Event.ID == thisEvent.ID).AnyAsync(); |
There was a problem hiding this comment.
[nit]: Can technically do .AnyAsync(tm => tm.Member.ID == ID ...) instead of the Where clause
| @@ -32,7 +32,7 @@ public async Task<IActionResult> OnGetAsync() | |||
| return Challenge(); | |||
| } | |||
|
|
|||
| if (!(await LoggedInUser.IsRegisteredForEvent(_context, Event))) | |||
| if (Event.HasIndividualRegistration && !(await LoggedInUser.IsRegisteredForEvent(_context, Event))) | |||
There was a problem hiding this comment.
Does a similar check need to happen in Team/Apply.cs?
Right now, it looks like if the player is not registered, they won't be able to apply for a team and will get redirected to register as a player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add concept of HasIndividualRegistration to Event object and adjust navigation flow based on it. Events that have individual registration will push players through that registration flow, events that don't will go back to the old flow of going directly to join/create team. This should also fix the previous event access bug.