Skip to content

Commit

Permalink
Disabling nameplate functionality since it appears to be partially br…
Browse files Browse the repository at this point in the history
…oken in ClientStructs for 6.2
  • Loading branch information
PunishedPineapple committed Aug 25, 2022
1 parent 77db534 commit f703fab
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Distance/Plugin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public Plugin(
mPluginInterface.UiBuilder.Draw += DrawUI;
mPluginInterface.UiBuilder.OpenConfigUi += DrawConfigUI;
mUI.Initialize();
NameplateHandler.Init( sigScanner, clientState, partyList, condition, gameGui, mConfiguration );
//NameplateHandler.Init( sigScanner, clientState, partyList, condition, gameGui, mConfiguration ); //***** TODO: Disabled because nameplates appear to be broken in ClientStructs for 6.2.

// We need to disable automatic hiding, because we actually turn off our game UI nodes in the draw functions as-appropriate, so we can't skip the draw functions.
mPluginInterface.UiBuilder.DisableAutomaticUiHide = true;
Expand Down
7 changes: 5 additions & 2 deletions Distance/PluginUI.cs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ protected void DrawSettingsWindow()
{
ImGui.Checkbox( Loc.Localize( "Config Option: Show Aggro Distance", "Show the remaining distance from the enemy before they will detect you." ) + "###Show aggro distance.", ref mConfiguration.mShowAggroDistance );
ImGuiUtils.HelpMarker( Loc.Localize( "Help: Show Aggro Distance", "This distance will only be shown when it is known, and only on major bosses. Additionally, it will only be shown until you enter combat." ) );
ImGui.Checkbox( Loc.Localize( "Config Option: Show Nameplate Distances", "Show distances on nameplates." ) + "###Show nameplate distances.", ref mConfiguration.NameplateDistancesConfig.mShowNameplateDistances );
//***** TODO: Nameplates are broken in 6.2; commenting out settings until fixed.
//ImGui.Checkbox( Loc.Localize( "Config Option: Show Nameplate Distances", "Show distances on nameplates." ) + "###Show nameplate distances.", ref mConfiguration.NameplateDistancesConfig.mShowNameplateDistances );

if( mConfiguration.ShowAggroDistance )
{
Expand Down Expand Up @@ -187,6 +188,8 @@ protected void DrawSettingsWindow()
}
}

//***** TODO: Nameplates are broken in 6.2; commenting out settings until fixed.
/*
if( mConfiguration.NameplateDistancesConfig.ShowNameplateDistances )
{
if( ImGui.CollapsingHeader( Loc.Localize( "Config Section Header: Nameplate Settings", "Nameplate Settings" ) + "###Nameplate Settings Header." ) )
Expand Down Expand Up @@ -252,7 +255,7 @@ protected void DrawSettingsWindow()
ImGui.TreePop();
}
}
}
}*/

if( ImGui.CollapsingHeader( Loc.Localize( "Config Section Header: Miscellaneous", "Miscellaneous Options" ) + "###Misc. Options Header." ) )
{
Expand Down

0 comments on commit f703fab

Please sign in to comment.