feat: routine verification #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexter2206
approved these changes
Jun 25, 2024
| return self.is_valid | ||
|
|
||
|
|
||
| def verify_routine_topology(routine: Routine) -> VerificationOutput: |
There was a problem hiding this comment.
issue (nonblocking): Missing Returns section. For the sake of how the docs look, I would add a simple paragraph like:
Returns:
An object indicating if the verification succeeded, containing a (possibly empty) list of found problems.
| return VerificationOutput(problems=verify_topology(qref_routine).problems) | ||
|
|
||
|
|
||
| def verify_uncompiled_routine(routine: Routine, backend: SymbolicBackend) -> VerificationOutput: |
There was a problem hiding this comment.
issue (nonblocking): Missing Returns section in docstrings.
| return f"Couldn't parse {object_type}: {original_object} of subroutine: {path}." | ||
|
|
||
|
|
||
| def verify_compiled_routine(routine: Routine, backend: SymbolicBackend) -> VerificationOutput: |
There was a problem hiding this comment.
issue (nonblocking): Missing Returns section in docstring.
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #18
Please verify that you have completed the following steps