Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HW requirements, node start commands, and node shell scripts #2

Closed
wants to merge 107 commits into from
Closed

Update HW requirements, node start commands, and node shell scripts #2

wants to merge 107 commits into from

Conversation

kpandl
Copy link

@kpandl kpandl commented May 24, 2024 •
edited
Loading

This PR changes the README.md file and the validator/client/prover shell scripts.

Rendered Version

For the README.md, the PR specifically:

  • provides updated HW requirements for validators/clients
  • removes official HW recommendations for provers
  • introduces the concept of core and outer clients
  • updates the recommended start commands of validators/clients

For the corresponding shell scripts, it:

  • makes use of the updated start commands
  • provides a shell script for core/outer clients instead of general clients
  • removes the automatic GitHub update loop (which could trigger a large number of nodes to go offline around the same time)

@kpandl kpandl changed the title Update HW Req., node start commands, and node shell scripts Update HW requirements, node start commands, and node shell scripts May 24, 2024
iamalwaysuncomfortable
iamalwaysuncomfortable reviewed Jun 3, 2024
View reviewed changes
Copy link

@iamalwaysuncomfortable iamalwaysuncomfortable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments on wording

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
kpandl and others added 9 commits June 3, 2024 16:48
@kpandl @iamalwaysuncomfortable
Update README.md
80f722b 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Update README.md
2b0a2fb 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Update README.md
a225af1 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Update README.md
e0ec38a 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Update README.md
4397f14 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Update README.md
a615c7c 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Update README.md
49c4d74 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl @iamalwaysuncomfortable
Apply suggestions from code review
e22a75d 
Co-authored-by: Mike Turner <[email protected]>
Signed-off-by: Konstantin Pandl <[email protected]>
@kpandl
fix typo and core client script
723b541
@kpandl kpandl marked this pull request as ready for review June 3, 2024 14:56
@kpandl kpandl requested review from howardwu, raychu86 and d0cd June 3, 2024 14:56
vicsn
vicsn reviewed Jun 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
Meshiest and others added 22 commits June 19, 2024 17:21
@Meshiest
fix(sync): fix client sync mutex deadlock and client block request stall
67b11b4
@zosorock
Merge pull request AleoNet#3321 from monadicus/fix-client-stall
fea092c 
fix(sync): Fix client sync RwLock deadlock and client block request stall
@zosorock
Merge pull request AleoNet#3318 from monadicus/fix-tcp-connect-bind
5d4de02 
fix(tcp): fix outbound tcp requests not respecting --node bind port
@zosorock
mediumnize all of them!
b66d41e
@zosorock
updating links
1dcda54
@zosorock
resizing resources
2e551cf
@zosorock
Merge branch 'mainnet-staging' into fix/readme-header-img
5c7c900 
Signed-off-by: Fabiano <[email protected]>
@zosorock
fine-tune resource class
47cf2b5 
Signed-off-by: Fabiano <[email protected]>
@zosorock
resource adjustment
3978495 
Signed-off-by: Fabiano <[email protected]>
@zosorock
modify runner
dab8a07 
Signed-off-by: Fabiano <[email protected]>
@zosorock
Merge pull request AleoNet#3323 from AleoNet/fix/readme-header-img
2830993 
Fix header image, links, build instructions, rightsize CI
@zosorock
snarkVM rev bump for Canary v0.3.0 release
44ae011 
Signed-off-by: Fabiano <[email protected]>
@zosorock
Merge pull request AleoNet#3325 from AleoNet/canary/v0.3.0
09aa62b 
Canary v0.3.0 release
@d0cd
Fix
3579199
@d0cd
Use large resource for node-router CI
94318f5
@zosorock
bump snarkVM rev to d170a9f
1a5a2d5 
Signed-off-by: Fabiano <[email protected]>
@zosorock
Merge pull request AleoNet#3333 from zosorock/testnet-beta/v0.3.0
bd45fc7 
Testnet Beta v0.3.0 release
@vicsn
Merge remote-tracking branch 'aleonet/mainnet-staging' into fix/snark…
2fc1eb5 
…vm-history-rev
@zosorock
Merge pull request AleoNet#3329 from ProvableHQ/fix/snarkvm-history-rev
878624d 
[Fix] snarkVM rev for `history` feature.
@kpandl
update README formatting
7ea2222
@kpandl
fix typo
a72232b
@kpandl
update README - add or larger preferred
197cfb1
@kpandl kpandl requested a review from vicsn July 2, 2024 15:09
vicsn
vicsn reviewed Jul 4, 2024
View reviewed changes
run-validator.sh Outdated Show resolved Hide resolved
vicsn
vicsn reviewed Jul 4, 2024
View reviewed changes
Copy link

@vicsn vicsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, as discussed please close and open new PR to AleoNet

@kpandl
Copy link
Author

kpandl commented Jul 5, 2024

Closing this PR, as opened here: AleoNet#3351

@kpandl kpandl closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamalwaysuncomfortable iamalwaysuncomfortable iamalwaysuncomfortable left review comments

@vicsn vicsn vicsn left review comments

@howardwu howardwu Awaiting requested review from howardwu

@raychu86 raychu86 Awaiting requested review from raychu86

@d0cd d0cd Awaiting requested review from d0cd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kpandl @vicsn @iamalwaysuncomfortable @christianwwwwwwww @Meshiest @zosorock @joske @howardwu @d0cd @apruden2008