[Feature] Enumerate registers for top level inputs & parameter names for nested structs #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nputs in getProgramInputs and getRecord functions
This was
linked to
issues
Jul 27, 2023
onetrickwolf
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For both a
StructorRecordtype, its concrete type is its name. However, if a struct is a parameter of a record or another struct, its parameter name is defined in the enclosing struct or record.In order to create automatically generated Input forms, the input name of the variable needs to be included. This PR changes the "name" field of nested structs from the struct type to the parameter "name". It also adds a field to identify the concrete struct.
Test Plan
Tests of the correct serialization accompany this struct.