Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Use the Visitor pattern for code generation. #2281

Closed
wants to merge 15 commits into from

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Feb 25, 2023

This PR,

  • Removes AssociatedConstants from the AST
  • Refactors the Visitor and Reconstructor traits.
  • Refactors the code generation pass to use the Visitor.

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #2281 (dbfe07b) into testnet3 (c8f6089) will increase coverage by 0.32%.
The diff coverage is 81.35%.

@@             Coverage Diff              @@
##           testnet3    #2281      +/-   ##
============================================
+ Coverage     77.94%   78.27%   +0.32%     
============================================
  Files           150      149       -1     
  Lines          4571     4571              
  Branches       4569     4569              
============================================
+ Hits           3563     3578      +15     
+ Misses         1008      993      -15     
Impacted Files Coverage Δ
...c/expressions/access/associated_function_access.rs 50.00% <ø> (ø)
...mpiler/ast/src/expressions/access/member_access.rs 50.00% <ø> (ø)
compiler/ast/src/expressions/access/mod.rs 57.14% <ø> (ø)
...ompiler/ast/src/expressions/access/tuple_access.rs 100.00% <ø> (ø)
compiler/ast/src/expressions/mod.rs 50.00% <ø> (ø)
compiler/ast/src/lib.rs 78.37% <ø> (ø)
compiler/passes/src/code_generation/mod.rs 100.00% <ø> (ø)
.../src/static_single_assignment/rename_expression.rs 94.54% <ø> (+0.85%) ⬆️
...mpiler/passes/src/symbol_table_creation/creator.rs 87.50% <ø> (ø)
compiler/passes/src/type_checking/check_program.rs 89.14% <ø> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d0cd d0cd closed this Feb 26, 2023
@d0cd
Copy link
Collaborator Author

d0cd commented Feb 26, 2023

Closing in favor of #2282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant