-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend testing #22
Draft
kellpossible
wants to merge
24
commits into
main
Choose a base branch
from
frontend-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Frontend testing #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move a lot of code out of `specification` into `run.rs` - move the prerequisite building and git cloning out of test into `run.rs`
@kellpossible can you remind me what the status is here? |
@apruden2008 I added a description to the PR |
A bunch of todo comments for how to implement the browser contributor testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicBool
instead ofArc<Mutex<bool>>>
.npm start
, and which starts at the beginning of the integration test only when required.A temporary test specification is available showing how to run the browser tests:
browser-tests.ron
TODO:
setup-frontend
, and allow it to be configured for an NPM run. See phase1-wasm request coordinator public settings AleoNet/aleo-setup#454 for the changes toaleo-setup
. Once that PR is merged,setup-frontend
will also need the updated wasm binaries to be committed. Ideally these would be pulled in automatically as part of some build process...npm start
is used, we want to use the headleass browser launched by this integration test instead. However, it is a handy debugging option, allowing one to in a sense replace the computer programmed browser to check/create a workflow.setup-frontend
in headless browser using thirtyfour, one thread per browser contributor. Perform the necessary user actions required to make a contribution.