Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize example folder and add a python example #80

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

edd34
Copy link

@edd34 edd34 commented Feb 13, 2021

I moved nodeJSAppExamples into "./examples/nodeJS" without changing folder structure or anything in the project.
I have added a project called oracle_arb_finder into "./examples/python" folder.

@edd34
Copy link
Author

edd34 commented Feb 16, 2021

A demo where I arb ETH/ZRX on Uniswap/Kyberswap
https://youtu.be/0Yg_OdEhgNI

@mikedeshazer
Copy link
Member

@edd34 the greatest issue with the merge is that there are many videos and other content that reference the nodejs example endpoints, so changing this would break those links and lead to a number of complaints (most likely). If you could resubmit a PR keeping file structure the same, we can merge this! Thanks for your contribution!

@edd34 edd34 marked this pull request as draft February 18, 2021 10:26
@edd34 edd34 marked this pull request as ready for review February 19, 2021 12:45
@edd34
Copy link
Author

edd34 commented Feb 19, 2021

@edd34 the greatest issue with the merge is that there are many videos and other content that reference the nodejs example endpoints, so changing this would break those links and lead to a number of complaints (most likely). If you could resubmit a PR keeping file structure the same, we can merge this! Thanks for your contribution!

Hello @mikedeshazer I revert the commit which moved the files from NodeJSAppExamples and I have inserted some comments and code formating along the way.

@kennisnutz
Copy link

@edd34 how can I get better at using the orfeed Package, Im new to programing but I understood mikes series very well and i want to explore any chance we can collaborate on something? will help me learn faster

@edd34
Copy link
Author

edd34 commented Apr 11, 2021

@edd34 how can I get better at using the orfeed Package, Im new to programing but I understood mikes series very well and i want to explore any chance we can collaborate on something? will help me learn faster

In order to ramp up quickly, try to use web3 and query the blockchain via OrFeed for prices.
Create a project and tag me on issue or PR @edd34 I'll review your code

@kennisnutz
Copy link

In order to ramp up quickly, try to use web3 and query the blockchain via OrFeed for prices.
Create a project and tag me on issue or PR @edd34 I'll review your code

ok well thank you I will do this within the next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants