Prevent PHP Notice: Undefined index: sum (#104)

* Prevent PHP notice fix #102 Signed-off-by: Marcel Berteler <[email protected]> * Prevent PHP notice fix #102 Signed-off-by: Marcel Berteler <[email protected]> --------- Signed-off-by: Marcel Berteler <[email protected]> Co-authored-by: Lukas Kämmerling <[email protected]>
PromPHP · Apr 24, 2023 · 82e42b5 · 82e42b5
1 parent 9b4850a
commit 82e42b5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Prometheus/Storage/APC.php b/src/Prometheus/Storage/APC.php
@@ -383,7 +383,7 @@ private function collectHistograms(): array
                     'name' => $metaData['name'] . '_sum',
                     'labelNames' => [],
                     'labelValues' => $decodedLabelValues,
-                    'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum']),
+                    'value' => $this->fromBinaryRepresentationAsInteger($histogramBuckets[$labelValues]['sum'] ?? 0),
                 ];
             }
             $histograms[] = new MetricFamilySamples($data);

diff --git a/src/Prometheus/Storage/APCng.php b/src/Prometheus/Storage/APCng.php
@@ -661,7 +661,7 @@ private function collectHistograms(): array
                     'name' => $metaData['name'] . '_sum',
                     'labelNames' => [],
                     'labelValues' => $decodedLabelValues,
-                    'value' => $this->convertIncrementalIntegerToFloat($histogramBuckets[$labelValues]['sum']),
+                    'value' => $this->convertIncrementalIntegerToFloat($histogramBuckets[$labelValues]['sum'] ?? 0),
                 ];
             }
             $histograms[] = new MetricFamilySamples($data);