api: added defaults #551
Merged
api: added defaults #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramikm
force-pushed
the
prevent_server_overload
branch
from
022fc72
to
6bbb8d0
Compare
aramikm
commented
Sep 24, 2024
| transform: true, | ||
| }), | ||
| ); | ||
| // TODO: should get replaced with the config |
There was a problem hiding this comment.
seems like config in graph api is not refactored yet!
aramikm
commented
Sep 24, 2024
| @@ -23,7 +23,7 @@ x-common-environment: &common-environment | |||
|
|
|||
| x-content-publishing-env: &content-publishing-env | |||
| START_PROCESS: content-publishing-api | |||
| FILE_UPLOAD_MAX_SIZE_IN_BYTES: 2000000000 | |||
| FILE_UPLOAD_MAX_SIZE_IN_BYTES: 500000000 | |||
There was a problem hiding this comment.
it seems like we can only upload files up to 500MB based on current setup and redis
aramikm
commented
Sep 24, 2024
| @@ -334,89 +334,6 @@ | |||
| "health" | |||
| ] | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
for some reason my IDE likes a lot to apply this change.
mattheworris
approved these changes
Sep 25, 2024
Co-authored-by: Matthew Orris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to #491
Solution
with @pairperson1
Steps to Verify: