Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate queue configs #319

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented Jul 31, 2024

For account-service and content-publishing-service:

  • Reorganize imports so that we can import using '#lib/' prefix instead of '../../../../lib/common/src//...'
  • Refactor BullMQ connection & queue definitions to a common module for each app
    • Avoids multiple instantiation of BullModule
    • Eliminates possible errors in defining the same queue in multiple modules with different defaults

Closes #288 #316

import * as QueueConstants from './queue.constants';

@Global()
@Module({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -22,6 +32,7 @@ export class AssetController {
description: 'Asset files',
type: FilesUploadDto,
})
@ApiResponse({ status: '2XX', type: UploadResponseDto })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this status mean?

Copy link
Contributor

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much refactoring, it's hard to read these changes. Looks like they're all mostly names changes for imports and some rearranging, ship it! If there's any logic changes that you want me to look at, would you mind tagging me?

@JoeCap08055 JoeCap08055 merged commit 0be2f53 into main Aug 1, 2024
6 checks passed
@JoeCap08055 JoeCap08055 deleted the chore/consolidate-queue-configs branch August 1, 2024 00:07
@JoeCap08055
Copy link
Contributor Author

So much refactoring, it's hard to read these changes. Looks like they're all mostly names changes for imports and some rearranging, ship it! If there's any logic changes that you want me to look at, would you mind tagging me?

Sorry, I should have been more clear--no logic changes here, just refectoring of imports for shared config use and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue config refactor and review
2 participants