-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate queue configs #319
Conversation
import * as QueueConstants from './queue.constants'; | ||
|
||
@Global() | ||
@Module({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -22,6 +32,7 @@ export class AssetController { | |||
description: 'Asset files', | |||
type: FilesUploadDto, | |||
}) | |||
@ApiResponse({ status: '2XX', type: UploadResponseDto }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this status mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much refactoring, it's hard to read these changes. Looks like they're all mostly names changes for imports and some rearranging, ship it! If there's any logic changes that you want me to look at, would you mind tagging me?
Sorry, I should have been more clear--no logic changes here, just refectoring of imports for shared config use and readability. |
For
account-service
andcontent-publishing-service
:BullModule
Closes #288 #316