-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Chore/refactor openapi generation (#569)
This PR does the following: - refactors the code to generate OpenAPI specs from the NestJS controllers into a common module that can be shared between services. - removes the path that automatically re-generated the OpenAPI spec file every time the service was launched. - adds the `@nestjs/swagger` CLI plugin. This eliminates the need to manually generate metadata, so that has been removed from all scripts - Eliminate manual use of `@ApiProperty()` decorators in _most_ places, and rely instead on the `@nestjs/swagger` package to infer endpoint types from the metadata. A notable exception to this is cases where properties are enums. - Some type cleanup to make sure the generated OpenAPI spec matches the actual types being returned as fully as possible - Added some cleanup to the `CacheMonitorService`; found that registered listeners on the Redis connections were causing application termination to hang. Closes #568 --------- Co-authored-by: Aramik <[email protected]>
- Loading branch information
1 parent
2840a33
commit 6dee360
Showing
84 changed files
with
3,686 additions
and
3,787 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
apps/content-publishing-api/src/controllers/v1/asset.controller.v1.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.