fix: change end-of-chain scan log message to debug instead of error (#…

…652)

# Problem

"Latest finalized block encountered" error messages spam the log.

# Solution

Changed the log level to `debug`.
Went back & forth between this & `verbose`; ultimately decided that even
at the verbose level it's too spammy.
Different opinions welcome in the comments section.

## Steps to Verify:

1. Run any gateway service with `DEBUG=true` in the environment
2. Let the scan run & watch the log
3. Logs about the scan reaching end-of-chain should be logged at the
`[DEBUG]` level

Closes #643

libs/account-lib/src/utils/blockchain-scanner.service.ts

@@ -14,7 +14,6 @@ export interface IBlockchainScanParameters {
 }
 
 export class EndOfChainError extends Error {}
-export class NullScanError extends Error {}
 
 function eventName({ event: { section, method } }: FrameSystemEventRecord) {
   return `${section}.${method}`;
@@ -92,12 +91,7 @@ export abstract class BlockchainScannerService {
       }
     } catch (e: any) {
       if (e instanceof EndOfChainError) {
-        this.logger.error(e.message);
-        return;
-      }
-
-      if (e instanceof NullScanError) {
-        this.logger.verbose(e.message);
+        this.logger.debug(e.message);
         return;
       }
 

libs/content-publishing-lib/src/utils/blockchain-scanner.service.ts

@@ -14,7 +14,6 @@ export interface IBlockchainScanParameters {
 }
 
 export class EndOfChainError extends Error {}
-export class NullScanError extends Error {}
 export class SkipBlockError extends Error {}
 
 function eventName({ event: { section, method } }: FrameSystemEventRecord) {
@@ -99,12 +98,7 @@ export abstract class BlockchainScannerService {
       }
     } catch (e) {
       if (e instanceof EndOfChainError) {
-        this.logger.error(e.message);
-        return;
-      }
-
-      if (e instanceof NullScanError) {
-        this.logger.verbose(e.message);
+        this.logger.debug(e.message);
         return;
       }
 

libs/content-watcher-lib/src/scanner/scanner.service.ts

@@ -118,7 +118,7 @@ export class ScannerService implements OnApplicationBootstrap, OnApplicationShut
         const currentBlockNumber = await this.getNextBlockNumber();
         const currentBlockHash = await this.blockchainService.getBlockHash(currentBlockNumber);
         if (currentBlockHash.isEmpty) {
-          this.logger.log(
+          this.logger.debug(
             `No new blocks to scan @ block number ${currentBlockNumber}; pausing scan until next interval`,
           );
           break;

libs/graph-lib/src/utils/blockchain-scanner.service.ts

@@ -14,7 +14,6 @@ export interface IBlockchainScanParameters {
 }
 
 export class EndOfChainError extends Error {}
-export class NullScanError extends Error {}
 export class SkipBlockError extends Error {}
 
 function eventName({ event: { section, method } }: FrameSystemEventRecord) {
@@ -99,12 +98,7 @@ export abstract class BlockchainScannerService {
       }
     } catch (e) {
       if (e instanceof EndOfChainError) {
-        this.logger.error(e.message);
-        return;
-      }
-
-      if (e instanceof NullScanError) {
-        this.logger.verbose(e.message);
+        this.logger.debug(e.message);
         return;
       }