fix: fix bugs found while testing

ProjectLibertyLabs · Sep 23, 2024 · 0840d1a · 0840d1a
1 parent 2db9cdc
commit 0840d1a
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 4 deletions.
diff --git a/apps/account-worker/src/transaction_notifier/notifier.service.helper.createWebhookRsp.ts b/apps/account-worker/src/transaction_notifier/notifier.service.helper.createWebhookRsp.ts
@@ -88,7 +88,7 @@ export function createWebhookRsp(
   }
 
   if (transactionType === TransactionType.SIWF_SIGNUP && isSiwfOpts(options)) {
-    return response as SIWFWebhookRsp;
+    return { ...response, ...options } as SIWFWebhookRsp;
   }
 
   throw new Error(`Invalid transaction type ${transactionType} for webhook response`);

diff --git a/apps/account-worker/src/transaction_notifier/notifier.service.ts b/apps/account-worker/src/transaction_notifier/notifier.service.ts
@@ -170,6 +170,7 @@ export class TxnNotifierService
                   accountId: siwfTxnValues.address,
                   handle: siwfTxnValues.handle,
                 });
+                webhookResponse = response;
 
                 this.logger.log(
                   `SIWF: ${siwfTxnValues.address} Signed up handle ${response.handle} for msaId ${response.msaId} delegated to provider ${siwfTxnValues.newProvider}.`,

diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -44,6 +44,8 @@ x-account-service-env: &account-service-env
   TRUST_UNFINALIZED_BLOCKS: true
   WEBHOOK_BASE_URL: 'http://mock-webhook-server:${ACCOUNT_WEBHOOK_PORT:-3001}/webhooks/account-service'
   GRAPH_ENVIRONMENT_TYPE: Mainnet
+  CACHE_KEY_PREFIX: 'account:'
+  DEBUG: true
 
 services:
   redis:

diff --git a/libs/types/src/enums/announcement-type.enum.ts b/libs/types/src/enums/announcement-type.enum.ts
@@ -6,7 +6,6 @@ export enum AnnouncementType {
   Reaction = 4,
   Profile = 5,
   Update = 6,
-  PublicFollows = 113,
 }
 
 // eslint-disable-next-line no-shadow

diff --git a/openapi-specs/content-announcement.openapi.json b/openapi-specs/content-announcement.openapi.json
@@ -33,8 +33,8 @@
   "components": {
     "schemas": {
       "AnnouncementType": {
-        "enum": [0, 2, 3, 4, 5, 6, 113],
-        "x-enum-varnames": ["Tombstone", "Broadcast", "Reply", "Reaction", "Profile", "Update", "PublicFollows"]
+        "enum": [0, 2, 3, 4, 5, 6],
+        "x-enum-varnames": ["Tombstone", "Broadcast", "Reply", "Reaction", "Profile", "Update"]
       },
       "AnnouncementResponse": {
         "type": "object",

diff --git a/package.json b/package.json
@@ -82,6 +82,7 @@
     "test:e2e:content-publishing": "dotenvx run -f env-files/content-publishing.template.env -- jest --testRegex \".e2e-spec.ts\" --detectOpenHandles 'content-publishing*'",
     "test:e2e:content-watcher": "dotenvx run -f env-files/content-watcher.template.env -- jest --testRegex \".e2e-spec.ts\" --detectOpenHandles 'content-watcher*'",
     "test:e2e:graph": "dotenvx run -f env-files/graph.template.env -- jest --testRegex \".e2e-spec.ts\" --detectOpenHandles 'graph*'",
+    "test:k6:account": "for t in apps/account-api/k6-test/*.k6.js ; do k6 run ${t} ; done",
     "format": "prettier --write .",
     "lint": "eslint apps/**/*.[tj]s libs/**/*.[tj]s",
     "lint:account": "eslint apps/account*/**/*.[tj]s libs/account-lib/**/*.[tj]s",