Skip to content

fix up for migrations and accessionId #3484

fix up for migrations and accessionId

fix up for migrations and accessionId #3484

Triggered via pull request July 3, 2024 11:04
Status Success
Total duration 5m 37s
Artifacts 3

test.yml

on: pull_request
unit-tests-and-codecov
3m 12s
unit-tests-and-codecov
workflow-executor-integration-tests
5m 19s
workflow-executor-integration-tests
task-manager-integration-tests
1m 47s
task-manager-integration-tests
Fit to window
Zoom out
Zoom in

Annotations

46 warnings
task-manager-integration-tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
task-manager-integration-tests: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
task-manager-integration-tests: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
unit-tests-and-codecov
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unit-tests-and-codecov: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
unit-tests-and-codecov: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
unit-tests-and-codecov: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
workflow-executor-integration-tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
workflow-executor-integration-tests: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
workflow-executor-integration-tests: tests/UnitTests/Common.Tests/Services/PayloadServiceTests.cs#L498
Converting null literal or possible null value to non-nullable type.
sonarscanner
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3, actions/download-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
sonarscanner: src/WorkflowManager/Contracts/Migrations/M004_WorkflowRevision_addConditions.cs#L23
Rename class 'M004_WorkflowRevision_addConditions' to match pascal case naming rules, consider using 'M004WorkflowRevisionaddConditions'. (https://rules.sonarsource.com/csharp/RSPEC-101)
sonarscanner: src/WorkflowManager/Contracts/Migrations/M003_WorkflowRevision_addDataRetension.cs#L23
Rename class 'M003_WorkflowRevision_addDataRetension' to match pascal case naming rules, consider using 'M003WorkflowRevisionaddDataRetension'. (https://rules.sonarsource.com/csharp/RSPEC-101)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L126
Remove the unnecessary Boolean literal(s). (https://rules.sonarsource.com/csharp/RSPEC-1125)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L133
Remove the unnecessary Boolean literal(s). (https://rules.sonarsource.com/csharp/RSPEC-1125)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L163
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L164
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L175
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L176
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L177
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
sonarscanner: src/WorkflowManager/Storage/Services/DicomService.cs#L199
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "code-coverage-reports", "TaskManagerIntegrationTestReport", "WorkflowExecutorIntegrationTestReport". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
TaskManagerIntegrationTestReport Expired
1.69 MB
WorkflowExecutorIntegrationTestReport Expired
2.65 MB
code-coverage-reports Expired
18.4 MB