Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai 627 #517

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Ai 627 #517

merged 1 commit into from
Jul 25, 2024

Conversation

neildsouth
Copy link
Contributor

Description

Fixes
sometimes the payload assembler cant get a connection to mongo, this causes the Mig to be in a sort of zombe state where its running and responding to health checks, but not processing.

Ive fixed the health checks to include the hosted services as well.

change the payloadAssembler to use a single instance of the payloadRepository.

Status

/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth neildsouth added the enhancement Enhancement to existing feature label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 78.97727% with 37 lines in your changes missing coverage. Please review.

Project coverage is 73.24226%. Comparing base (9bc789b) to head (8ef63a2).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #517         +/-   ##
===================================================
- Coverage   73.24711%   73.24226%   -0.00486%     
===================================================
  Files            444         445          +1     
  Lines          29922       29939         +17     
  Branches        1421        1427          +6     
===================================================
+ Hits           21917       21928         +11     
- Misses          7464        7468          +4     
- Partials         541         543          +2     
Flag Coverage Δ
unittests 73.24226% <78.97727%> (-0.00486%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Api/Storage/Payload.cs 91.66667% <100.00000%> (+0.17730%) ⬆️
src/InformaticsGateway/Program.cs 80.67227% <100.00000%> (-0.16107%) ⬇️
...rmaticsGateway/Services/Export/Hl7ExportService.cs 93.44262% <100.00000%> (ø)
...teway/Test/Repositories/MonaiServiceLocatorTest.cs 100.00000% <100.00000%> (ø)
...eway/Test/Services/Export/ExportHl7ServiceTests.cs 99.59184% <100.00000%> (+0.00168%) ⬆️
...eway/Test/Services/HealthLevel7/MllpServiceTest.cs 100.00000% <100.00000%> (ø)
...Gateway/Test/Services/Http/MonaiHealthCheckTest.cs 100.00000% <100.00000%> (ø)
...rmaticsGateway/Repositories/MonaiServiceLocator.cs 92.30769% <80.00000%> (-3.14687%) ⬇️
...icsGateway/Services/Connectors/PayloadAssembler.cs 84.44444% <83.33333%> (-0.26144%) ⬇️
...formaticsGateway/Services/Http/MonaiHealthCheck.cs 83.33333% <66.66667%> (-5.55556%) ⬇️
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc789b...8ef63a2. Read the comment docs.

Signed-off-by: Neil South <[email protected]>
@neildsouth neildsouth merged commit c41faaf into develop Jul 25, 2024
28 of 30 checks passed
@neildsouth neildsouth deleted the AI-627 branch July 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants