Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8.0 #506

Merged
merged 19 commits into from
Jan 9, 2024
Merged

Upgrade to .NET 8.0 #506

merged 19 commits into from
Jan 9, 2024

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Dec 15, 2023

Description

.NET 8.0 LTS upgrade

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp added enhancement Enhancement to existing feature dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Dec 15, 2023
@mocsharp mocsharp added this to the 0.5.0 milestone Dec 15, 2023
@mocsharp mocsharp self-assigned this Dec 15, 2023
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 233 lines in your changes are missing coverage. Please review.

Comparison is base (3f3a9f4) 74.87277% compared to head (eeddc9f) 65.39580%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #506         +/-   ##
===================================================
- Coverage   74.87277%   65.39580%   -9.47698%     
===================================================
  Files            434         374         -60     
  Lines          28885       21324       -7561     
  Branches        1249        1331         +82     
===================================================
- Hits           21627       13945       -7682     
- Misses          6806        6874         +68     
- Partials         452         505         +53     
Flag Coverage Δ
unittests 65.39580% <76.97628%> (-9.47698%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Api/LoggingDataDictionary.cs 100.00000% <ø> (+33.33333%) ⬆️
src/Api/Rest/InferenceRequestException.cs 33.33333% <ø> (+8.33332%) ⬆️
src/Api/Storage/FileStorageMetadata.cs 84.61538% <ø> (-3.38462%) ⬇️
src/Api/Test/Storage/PayloadTest.cs 100.00000% <100.00000%> (ø)
src/CLI/Commands/AetCommand.cs 97.41697% <100.00000%> (ø)
src/CLI/Commands/CommandBase.cs 86.36364% <ø> (ø)
src/CLI/Commands/ConfigurationException.cs 33.33333% <ø> (+8.33332%) ⬆️
src/CLI/ControlException.cs 25.00000% <ø> (-35.00000%) ⬇️
src/CLI/Logging/ConsoleLogger.cs 92.85714% <ø> (ø)
src/CLI/Services/ConfigurationService.cs 100.00000% <100.00000%> (ø)
... and 88 more

... and 72 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3a9f4...eeddc9f. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 11721d4 into develop Jan 9, 2024
28 of 31 checks passed
@mocsharp mocsharp deleted the vchang/net8 branch January 9, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Enhancement to existing feature .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants