Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-435 Fix CLI to read log dir path from NLog config file #436

Merged
merged 3 commits into from
Aug 10, 2023

Add/update unit tests

153b3f5
Select commit
Loading
Failed to load commit list.
Merged

gh-435 Fix CLI to read log dir path from NLog config file #436

Add/update unit tests
153b3f5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 10, 2023 in 1s

79.23846% (+0.37706%) compared to d54788e

View this Pull Request on Codecov

79.23846% (+0.37706%) compared to d54788e

Details

Codecov Report

Merging #436 (153b3f5) into develop (d54788e) will increase coverage by 0.37706%.
The diff coverage is 97.90210%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #436         +/-   ##
===================================================
+ Coverage   78.86140%   79.23846%   +0.37706%     
===================================================
  Files            336         339          +3     
  Lines          21184       21299        +115     
  Branches         964         969          +5     
===================================================
+ Hits           16706       16877        +171     
+ Misses          4160        4103         -57     
- Partials         318         319          +1     
Files Changed Coverage Δ
src/CLI/Program.cs 35.84906% <0.00000%> (-1.40584%) ⬇️
src/CLI/Services/EmbeddedResource.cs 0.00000% <0.00000%> (ø)
src/CLI/Test/ProgramTest.cs 100.00000% <ø> (ø)
src/CLI/Options/Common.cs 100.00000% <100.00000%> (ø)
src/CLI/Services/ConfigurationOptionAccessor.cs 100.00000% <100.00000%> (+96.72131%) ⬆️
src/CLI/Services/ConfigurationService.cs 100.00000% <100.00000%> (ø)
src/CLI/Services/DockerRunner.cs 100.00000% <100.00000%> (ø)
...rc/CLI/Services/NLogConfigurationOptionAccessor.cs 100.00000% <100.00000%> (ø)
src/CLI/Test/ConfigurationOptionAccessorTest.cs 100.00000% <100.00000%> (ø)
src/CLI/Test/ConfigurationServiceTest.cs 100.00000% <100.00000%> (ø)
... and 2 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54788e...153b3f5. Read the comment docs.