Refactor & Add test for watcher_unix #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphagocc
reviewed
Aug 10, 2023
|
更新：符号链接不用处理， 内存限制还有点问题，原来没考虑负数的情况。明天再改改。 |
Dust1404
changed the title
alphagocc
pushed a commit
that referenced
this pull request
Aug 16, 2023
* add test for watcher_unix * fix watcher_unix * add test for watcher_unix * resolve comments * add comment for parse fileName * refactor watcher_unix * add unlimited memory & TLE test * fix macos build * format code * no need to resolve symlink * add testcases * minor fix * minor fix (consistent) * remove duplicate include * add more testcases for watcher_unix * rename RE test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #216
同时修复了添加 test 过程中发现的 MacOS 的内存限制错误的 Bug（memoryLimit 单位不统一导致）。
重构了
watcher_unix的代码，合并了 Linux 和 MacOS 版本的公共代码，将差异的部分提出成两个文件。加了一些注释。给
watcher_unix加了点测试用例，防止之后的贡献再出现上次的疏漏。目前的测试点有如下：
欢迎添加更多的测试用例增大测试覆盖率。