Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pseventbus v4 #341

Open
wants to merge 150 commits into
base: main
Choose a base branch
from
Open

refactor: pseventbus v4 #341

wants to merge 150 commits into from

Conversation

fox-john
Copy link
Contributor

@fox-john fox-john commented Jul 26, 2024

What's in?

Refactoring the whole synchronization process, sorting shopContents repositories and controllers.

Breaking changes

  • Since version 4.0, all API endpoints are grouped under a single controller "apiShopContent.php" (except for the healthcheck). The route to call is now unique, and the shopContent is no longer a specific endpoint but a query parameter of the request:
    http://localhost:8000/index.php?fc=module&module=ps_eventbus&controller=apiShopContent&shop_content=products

@fox-john fox-john self-assigned this Jul 26, 2024
@fox-john fox-john added the 🚧 WIP Status: Work In Progress label Jul 26, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@cnavarro-prestashop cnavarro-prestashop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 derniers commentaires et pour moi c'est bon. Well done !

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥕 Radis to review Ready to reviewed by 1 peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants