This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Fix rounding error in new order email #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆙 |
|
Anybody? |
mcdado
changed the title
The previous values are rounded to 2 decimals in the following method: 1. Order::getOrders() 2. Order::getProductsDetail() 3. Order::setProductPrices() This is due to backwards compatibility with 1.4, but it can lead to rounding errors in the product lines in the email. Instead, here we are using other values provided by the Core.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous values are rounded to 2 decimals in the following method:
This is due to backwards compatibility with 1.4, but it can lead to rounding errors in the product lines in the email. Instead, here we are using other values provided by the Core.
See example screenshot, where the total is not aligned with the product total:
Please note how the total in the product line is not the same as the product total below. The minus-minus on the coupon line is another issue, precisely: #25