Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate prefect-aws to core #12888

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Migrate prefect-aws to core #12888

merged 5 commits into from
Apr 25, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Apr 24, 2024

@zzstoatzz zzstoatzz requested review from a team as code owners April 24, 2024 22:18
@zzstoatzz zzstoatzz added the integrations Related to integrations with other services label Apr 24, 2024
@zzstoatzz zzstoatzz self-assigned this Apr 24, 2024
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit a0b2db6
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/66298546df43ff0008bea982
😎 Deploy Preview https://deploy-preview-12888--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +33 to +35
# Install all integration libraries from src/integrations and core dev dependencies as editable
integration_packages=$(find src/integrations -name "pyproject.toml" -exec dirname {} \;)
uv pip install $integration_packages

# Install the prefect package in editable mode
uv pip install -e ".[dev]"
uv pip install $integration_packages -e ".[dev]"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it in one step to make it faster

src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/prefect_aws/secrets_manager.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/tests/test_credentials.py Dismissed Show dismissed Hide dismissed
src/integrations/prefect-aws/tests/test_credentials.py Dismissed Show dismissed Hide dismissed
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 512d5ad
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/662a5cffa2861800086e458f
😎 Deploy Preview https://deploy-preview-12888--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zzstoatzz zzstoatzz merged commit f847716 into main Apr 25, 2024
19 checks passed
@zzstoatzz zzstoatzz deleted the migrate-prefect-aws branch April 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Related to integrations with other services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate prefect-aws to core
2 participants