Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improvement/error handling task creation #406

Merged
merged 9 commits into from
Apr 11, 2024

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Apr 2, 2024

Introduces logic to catch failures from the run task response. It raises a RuntimeError when it finds the list of failures populated of if either tasks or failures which will help with the index errors that can come up.

Closes #282

Example

Screenshots

Checklist

  • [ x ] References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • [ x ] Includes tests or only affects documentation.
  • [ x ] Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.

@jeanluciano jeanluciano marked this pull request as ready for review April 2, 2024 21:01
@jeanluciano jeanluciano requested a review from a team as a code owner April 2, 2024 21:01
@jeanluciano jeanluciano self-assigned this Apr 2, 2024
tests/workers/test_ecs_worker.py Outdated Show resolved Hide resolved
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeanluciano jeanluciano merged commit f9e5e9b into main Apr 11, 2024
7 checks passed
@jeanluciano jeanluciano deleted the improvement/error-handling-task-creation branch April 11, 2024 14:10
@MohammedSiddiqui
Copy link

@jeanluciano thanks for taking care of this!
@desertaxle any idea when these changes can be available now in a new release?

@rmnvncnt
Copy link

Thanks a lot for that one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error, if ECS task can not be submitted
4 participants